Fix old-arch component not updating background in interop layer example #36924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 2b4e1f5 |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 6dcdd2e. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…le (facebook#36924) Summary: I've noticed that in the Fabric Interop Layer sample on RN-Tester, when running with Old Arch, the legacy view is not receiving the commands correctly. This is due to us not sending the command as string, which is making the command fail to deliver. ## Changelog: [INTERNAL] - Fix old-arch component not updating background in interop layer example Pull Request resolved: facebook#36924 Test Plan: Tested locally: | Before | After | |--------|--------| |  |  | Reviewed By: cipolleschi Differential Revision: D45043929 Pulled By: cortinico fbshipit-source-id: 8bb2a052a1a600046f3a16c868062c5e600385f0
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…le (facebook#36924) Summary: I've noticed that in the Fabric Interop Layer sample on RN-Tester, when running with Old Arch, the legacy view is not receiving the commands correctly. This is due to us not sending the command as string, which is making the command fail to deliver. ## Changelog: [INTERNAL] - Fix old-arch component not updating background in interop layer example Pull Request resolved: facebook#36924 Test Plan: Tested locally: | Before | After | |--------|--------| |  |  | Reviewed By: cipolleschi Differential Revision: D45043929 Pulled By: cortinico fbshipit-source-id: 8bb2a052a1a600046f3a16c868062c5e600385f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I've noticed that in the Fabric Interop Layer sample on RN-Tester, when running with Old Arch, the legacy view is not receiving the commands correctly.
This is due to us not sending the command as string, which is making the command fail to deliver.
Changelog:
[INTERNAL] - Fix old-arch component not updating background in interop layer example
Test Plan:
Tested locally: